Add ParseFixed6 equivalent of ParseInt #6618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephphatha
force-pushed
the
fixedParse
branch
from
ee49d3a to
62eff65
Compare
glebm
reviewed
Sep 17, 2023
glebm
approved these changes
Sep 17, 2023
|
It's wild that basic stuff like this isn't part of std :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended for use loading fixed point decimals from strings (e.g. player attributes from text files). Found a few error conditions that I wasn't handling properly so made the code a bit more robust at the expense of added lines :( e: and of course I found another failure case after opening the PR...
Split from #6530